Added support for lifecycle/subplugins.php page#27
Merged
Conversation
ScottVerbeek
commented
Mar 5, 2026
ScottVerbeek
commented
Member
- added a get_plugin_name()
- refactored the get_plugin_description()
- refactored language pack
There was a problem hiding this comment.
Pull request overview
Adds missing metadata accessors/strings so this lifecycle step can be correctly displayed in the lifecycle subplugins.php UI.
Changes:
- Introduces
get_plugin_name()on the lifecycle step to expose the display name. - Refactors
get_plugin_description()to use a dedicatedplugindescriptionlanguage string. - Updates the English language pack by adding
plugindescriptionand removing the unuseddescriptionkey.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lang/en/tool_lcbackupcoursestep.php | Adds plugindescription string and removes the old description key. |
| classes/lifecycle/step.php | Adds get_plugin_name() and updates get_plugin_description() to use plugindescription. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @ScottVerbeek , is there a trick I need to use to make the sub plugins visible? I've installed all of the plugins, but only the ones in the base plugin seem to appear. 
|
owenherbert-catalyst
self-requested a review
March 5, 2026 02:19
Member
Author
|
Hey Owen this would work with the branch used in : learnweb/moodle-tool_lifecycle#293 |
|
LGTM! |
|
I've just tested the version bump commit alongside the other sub-plugins and it works as expected. |
owenherbert-catalyst
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.